Conversation
Greptile SummaryThis PR implements Confidence Score: 4/5Safe to merge; only P2 style/robustness issues found, no logic or security bugs. All findings are P2: non-deterministic sort order for same-named cells across libraries in write_sdc, and missing explanatory comments on two complex code blocks per the team's documentation rule. No P0 or P1 issues identified. sdc/WriteSdc.cc — lib-cell sort comparator and missing comments on writeDisabledClockGatingChecks. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["set_disable_clock_gating_check {objects}"] --> B{Object type}
B -->|get_lib_cells| C["disable_clock_gating_check_lib_cell(cell)\n→ Sdc::disabled_clk_gating_checks_lib_cell_"]
B -->|get_cells| D["disable_clock_gating_check_inst(inst)\n→ Sdc::disabled_clk_gating_checks_inst_"]
B -->|get_pins| E["disable_clock_gating_check_pin(pin)\n→ Sdc::disabled_clk_gating_checks_pin_"]
B -->|get_ports| F["disable_clock_gating_check_pin(get_port_pin)\n→ Sdc::disabled_clk_gating_checks_pin_"]
G["GatedClk::isGatedClkEnable / gatedClkEnables"] --> H["isDisableClockGatingCheck(pin)"]
G --> I["isDisableClockGatingCheck(inst)"]
I --> J{inst in disabled_inst set?}
J -->|yes| K[return true]
J -->|no| L["network_->libertyCell(inst)"]
L --> M{cell in disabled_cell set?}
M -->|yes| K
M -->|no| N[return false]
O["write_sdc → writeDisabledClockGatingChecks()"] --> P["Write set_disable_clock_gating_check\nfor lib cells / instances / pins"]
Reviews (1): Last reviewed commit: "set_disable_clock_gating_check" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
1 participant
No description provided.